what's wrong with this code to use clojure.java.jdbc/insert -

-

i tried use java.jdbc insert! function, can receive multiple objects. clojure.java.jdbc/insert! should called this:

(clojure.java.jdbc/insert! db {:name "john" :password "123"} {:name "george" :password "234"})

i defined function add multiple user records:

(defn add-users [user & more]    (-add-users db-spec user more))  (defmacro -add-users    ([db user] `(j/with-db-connection [con-db# db]                            (j/insert! con-db# ~user)))    ([db user & more] (let [users (-mk-user-list user more)]                        `(j/with-db-connection [con-db# db]                           (j/insert! con-db# ~@(flatten users))))) (defmacro -mk-usre-list   ([user] `~user)   ([user & more] `(list ~user (-mk-user-list ~@more))))

when macroexpand -add-users, looks result ok this:

=> (macroexpand '(-add-users db-spec {:name "john" :password "1234"}))   (let* [db-spec__21320__auto__ db-spec] (clojure.core/with-open [con__21321__auto__ (clojure.java.jdbc/get-connection db-spec__21320__auto__)] (clojure.core/let [con-db__23557__auto__ (clojure.java.jdbc/add-connection db-spec__21320__auto__ con__21321__auto__)] (clojure.java.jdbc/insert! con-db__23557__auto__ {:name "john", :password "1234"}))))

but when run :

=> (add-users {:name "john" :password "1234"})  illegalargumentexception insert called columns no values  clojure.java.jdbc/insert-sql (jdbc.clj:992)

what's wrong macro? or how should wrap , pass number of arguments function insert! needs arguments flattened?

[update] problem found: insert! needs table while in code it's not there.

(j/insert! con-db# ~user) should (j/insert! con-db# :users ~user) (j/insert! con-db# ~@(flatten users)) should (j/insert! con-db# :users ~@(flatten users))

but there anyway simpler it?

you can solve without macro, using apply:

user=> (doc apply) ------------------------- clojure.core/apply ([f args] [f x args] [f x y args] [f x y z args] [f b c d & args])   applies fn f argument list formed prepending intervening arguments args.  (defn my-insert! [x & more]   (apply jdbc/insert! db :table x more))

Comments

Post a Comment

Popular posts from this blog

yii2 - Yii 2 Running a Cron in the basic template -

-
i have seen instructions on running cron in advanced template, cant figure out how on basic template. have following controller in basic controllers folder. <?php namespace app\controllers; use yii\console\controller; /** * cron controller */ class croncontroller extends controller { public function actionindex() { echo "cron service runnning"; } public function actionmail($to) { echo "sending mail " . $to; } } i have navigated root of application , tried these comands yii cron php yii cron im getting unknown comand "cron" i know old question failed find actual answer this. if @ code yii exec file you'll notice requires /common/config/aliases.php file console/config/main.php. can naturally change these or copy on these advanced template. hope solves problem wanting same thing.
Read more

asp.net - 'System.Web.HttpContext' does not contain a definition for 'GetOwinContext' Mystery -

-
i realize question might seem trivial some, it's these types of things find myself fighting quite bit , want make sense of despite seeming losing battle in .net (for me anyway). so, if following: using system.web; ... applicationuser user = system.web.httpcontext.getowincontext().getusermanager<applicationusermanager>().findbyid(system.web.httpcontext.user.identity.getuserid()); that produces error in title , red getowincontext() , error cannot resolve symbol 'getowincontext()' however, if following (remove system.web in front of httpcontext ), works expected (or @ least no errors): using system.web; ... applicationuser user = httpcontext.getowincontext().getusermanager<applicationusermanager>().findbyid(system.web.httpcontext.user.identity.getuserid()); however, if (same line that's working using system.web commented out): //using system.web; ... applicationuser user = httpcontext.getowincontext().getusermana...
Read more

mercurial graft feature, can it copy? -

-
there new feature in mercurial 3, called 'graft' (graft local). job of moving change-set different branch. is there way "copy" change-set branch? i interested in in moving stuff qa branch production branch, still need code reside in qa. want copy. found , have tried few things, maybe it'll become clear more tinkering , reading... does have better way of 'cherry picking' change-sets move cross branch (or trunk)??? graft copies changesets, doesn't move them. hg graft (emphasis mine): this command uses mercurial's merge logic copy individual changes other branches without merging branches in history graph. known 'backporting' or 'cherry-picking' . default, graft copy user, date, , description source changesets.
Read more